Quebec City is beautiful and a highlight of this itinerary. Unfortunately, the day we were there, it was pouring rain and windy with hail, so we ended up running in and out of shops. There are fabulous little Bistros, stores and amazing views of the Chateau Frontenac. This is wonderful city.
Montreal is fabulous. It's a taste of Europe in North America. Even if your French isn't good, English is widely spoken. We only had a night here, and didn't even scratch the surface. The downtown area is great, as is the old town. Great restaurants, bars, clubs and shops can be found anywhere.